Skip to content
  • Arnd Bergmann's avatar
    537b5c84
    media: staging/imx: always select VIDEOBUF2_DMA_CONTIG · 537b5c84
    Arnd Bergmann authored
    
    
    I ran into a rare build error during randconfig testing:
    
    drivers/staging/media/imx/imx-media-capture.o: In function `capture_stop_streaming':
    imx-media-capture.c:(.text+0x224): undefined reference to `vb2_buffer_done'
    drivers/staging/media/imx/imx-media-capture.o: In function `imx_media_capture_device_register':
    imx-media-capture.c:(.text+0xe60): undefined reference to `vb2_queue_init'
    imx-media-capture.c:(.text+0xfa0): undefined reference to `vb2_dma_contig_memops'
    
    While VIDEOBUF2_DMA_CONTIG was already selected by the camera driver,
    it wasn't necessarily there with just the base driver enabled.
    This moves the 'select' statement to the top-level option to make
    sure it's always available.
    
    Fixes: 64b5a49d ("[media] media: imx: Add Capture Device Interface")
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarSteve Longerbeam <steve_longerbeam@mentor.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    537b5c84
    media: staging/imx: always select VIDEOBUF2_DMA_CONTIG
    Arnd Bergmann authored
    
    
    I ran into a rare build error during randconfig testing:
    
    drivers/staging/media/imx/imx-media-capture.o: In function `capture_stop_streaming':
    imx-media-capture.c:(.text+0x224): undefined reference to `vb2_buffer_done'
    drivers/staging/media/imx/imx-media-capture.o: In function `imx_media_capture_device_register':
    imx-media-capture.c:(.text+0xe60): undefined reference to `vb2_queue_init'
    imx-media-capture.c:(.text+0xfa0): undefined reference to `vb2_dma_contig_memops'
    
    While VIDEOBUF2_DMA_CONTIG was already selected by the camera driver,
    it wasn't necessarily there with just the base driver enabled.
    This moves the 'select' statement to the top-level option to make
    sure it's always available.
    
    Fixes: 64b5a49d ("[media] media: imx: Add Capture Device Interface")
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarSteve Longerbeam <steve_longerbeam@mentor.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
Loading